Project

General

Profile

Feature #89

Change icon for HTML mail and other mail with attachments at summaryview

Added by Kentaro Hayashi almost 10 years ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Category:
Sylpheed
Target version:
Start date:
08/18/2012
Due date:
% Done:

0%

Estimated time:

Description

Why:

I want to distinct HTML mail(text/plain,text/html) and other mail with attachments at a glance.
Currently, Sylpheed does not care about content of attachments for its icon.

Goal:

- use clip icon for mail with almost attachements at summaryview
- use other icon for HTML mail at summaryview

How:

Apply the attached patch for svn HEAD.

ref: http://d.hatena.ne.jp/kenhys/20120818


Files

#1

Updated by Hiroyuki Yamamoto almost 10 years ago

I've looked into your patch.

It will scan all MIME messages every time a folder is open.
This will have the non-trivial impact on the performance.

I think it should be done in libsylph and its results should be cached in .sylpheed_cache.

#2

Updated by Kentaro Hayashi almost 10 years ago

There is a performance problem certainly as you have mentioned above.

So, I have updated the patch which stores flags in .sylpheed_cache.
(Note that it occupies 1bit of MsgTmpFlags for HTML mail.)

#3

Updated by Kentaro Hayashi almost 10 years ago

Kentaro HAYASHI wrote:

There is a performance problem certainly as you have mentioned above.

So, I have updated the patch which stores flags in .sylpheed_cache.
(Note that it occupies 1bit of MsgTmpFlags for HTML mail.)

Sorry, I have attached wrong patch. I will update later.

#4

Updated by Kentaro Hayashi almost 10 years ago

I have updated the patch.

This patch fixes a bug that mime type is classified incorrectly as previous patch does.

#5

Updated by Hiroyuki Yamamoto almost 10 years ago

Kentaro HAYASHI wrote:

I have updated the patch.

This patch fixes a bug that mime type is classified incorrectly as previous patch does.

1. It is better to process MIME headers in procheader.c than in procmsg_write_cache().
The problem of the first patch will be solved by changing the definition of
MSG_CACHED_FLAG_MASK from (MSG_MIME) to (MSG_MIME|MSG_MIME_HTMLMAIL).
2. Created MimeInfo object is not freed.

#6

Updated by Hiroyuki Yamamoto almost 10 years ago

  • Status changed from New to In Progress
#7

Updated by Hiroyuki Yamamoto almost 9 years ago

  • Target version changed from 3.3 to 3.4
#8

Updated by Hiroyuki Yamamoto almost 9 years ago

I have modified your patch to:
  • process MIME header in procheader.c
  • replace HTML icon with Gnome's one
  • also treat HTML-only mail as HTML mail

and applied at svn r3281. Thanks!

#9

Updated by Hiroyuki Yamamoto almost 9 years ago

  • Status changed from In Progress to Resolved
#10

Updated by Kentaro Hayashi almost 9 years ago

I was going to update patch at that time, but I have not done for a long time.
Anyway, I am glad to hear this feature is implemented! Thanks!!!

#11

Updated by Hiroyuki Yamamoto over 8 years ago

  • Status changed from Resolved to Closed
#12

Updated by X. W. over 8 years ago

Hello,

i just upgraded from Sylpheed 3.3.0 Win32 to Sylpheed 3.4beta7 Win32 and noticed the new icon for HTML e-mails (which was introduced in Sylpheed 3.4beta6).

But the new icon only appears for HTML e-mails which have been received with Sylpheed 3.4beta6 (and newer).

So, e-mails which already have been received with Sylpheed 3.4beta5 (and older) do still show the old attachment icon.

Is it possible to let the new HTML icon show up for e-mails which already have been received with Sylpheed 3.4beta5 (and older) as well?

If yes: how?

Regards

#13

Updated by D Sciurus over 8 years ago

X. W. wrote:

Hello,

i just upgraded from Sylpheed 3.3.0 Win32 to Sylpheed 3.4beta7 Win32 and noticed the new icon for HTML e-mails (which was introduced in Sylpheed 3.4beta6).

But the new icon only appears for HTML e-mails which have been received with Sylpheed 3.4beta6 (and newer).

So, e-mails which already have been received with Sylpheed 3.4beta5 (and older) do still show the old attachment icon.

Is it possible to let the new HTML icon show up for e-mails which already have been received with Sylpheed 3.4beta5 (and older) as well?

If yes: how?

Regards

Ctrl+Alt+U or select Update the message summary in the View menu (main window)

#14

Updated by boddy massage 2 months ago

We are one of the best body massage service providers in bangalore. Call us for female to male full body massage. We are Offering professional full body massage in bangalore.

http://boddymsg.com/
http://boddymsg.com/services.html
http://boddymsg.com/contact.html
http://boddymsg.com/body_to_body_msg_bang.html
http://boddymsg.com/female_to_male_msg.html
http://boddymsg.com/spa_near_mebang.html
http://boddymsg.com/swedish_msg_bang.html
http://boddymsg.com/ban_msg_center.html
http://boddymsg.com/erotic_msg_bang.html
http://boddymsg.com/hot_stone_massage.html
http://boddymsg.com/full_body_msg.html
http://boddymsg.com/happy_ending_msg.html
http://boddymsg.com/ladies_parlour_me.html
http://boddymsg.com/deep_tissue_msg.html
http://boddymsg.com/female_to_male.html
http://boddymsg.com/body_msg.html
http://boddymsg.com/sensual_msg.html
http://boddymsg.com/body_to_body_spa_nearme.html
http://boddymsg.com/aromatherapy_msg_bang.html
http://boddymsg.com/thai_spa_near_me.html
http://boddymsg.com/nuru_msg_bangalore.html
http://boddymsg.com/msg_center_near_me_bangalore.html
http://boddymsg.com/couples_msg_bang.html
http://boddymsg.com/body_msg_spa_near_me.html
http://boddymsg.com/msg_par_near_me.html
http://boddymsg.com/carn_therapy.html
http://boddymsg.com/msg_spa_near_me.html
http://boddymsg.com/massage_spa.html
http://boddymsg.com/sarjapura.html
http://boddymsg.com/jigani.html
http://boddymsg.com/chandapura.html
http://boddymsg.com/anekal.html
http://boddymsg.com/attibele.html
http://boddymsg.com/madiwala.html
http://boddymsg.com/bommanahalli.html
http://boddymsg.com/yaswanthpur.html
http://boddymsg.com/yelahanka.html
http://boddymsg.com/mathikere.html
http://boddymsg.com/jalahalli.html
http://boddymsg.com/kammanahalli.html
http://boddymsg.com/ramamurthy_nagar.html
http://boddymsg.com/banaswadi.html
http://boddymsg.com/kalyan_nagar.html
http://boddymsg.com/bellundur.html
http://boddymsg.com/sadashivanagar.html
http://boddymsg.com/frazer_town.html
http://boddymsg.com/rajaji_nagar.html
http://boddymsg.com/malleshwaram.html
http://boddymsg.com/jaya_nagar.html
http://boddymsg.com/basavangudi.html
http://boddymsg.com/indira_nagar.html
http://boddymsg.com/KR_Market.html
http://boddymsg.com/KR_Puram.html
http://boddymsg.com/koramangala.html
http://boddymsg.com/marathahalli.html
http://boddymsg.com/bannerghatta_road.html
http://boddymsg.com/hebbal.html
http://boddymsg.com/JP_nagar.html
http://boddymsg.com/HSR_layout.html
http://boddymsg.com/lalbagh.html
http://boddymsg.com/electronic_city.html
http://boddymsg.com/whitfield.html
http://boddymsg.com/brookefield.html
http://boddymsg.com/banashankari.html
http://boddymsg.com/majestic.html
http://boddymsg.com/shivaji_nagar.html
http://boddymsg.com/victoria_layout.html
http://boddymsg.com/jayanagar.html
http://boddymsg.com/all_over_bangalore.html
http://boddymsg.com/bangalore.html
http://boddymsg.com/index.html
http://kamasutramsg.in/
http://kamasutramsg.in/index.html

Also available in: Atom PDF