Feature #89

Change icon for HTML mail and other mail with attachments at summaryview

Added by Kentaro HAYASHI almost 2 years ago. Updated 6 months ago.

Status:ClosedStart date:08/18/2012
Priority:NormalDue date:
Assignee:Hiroyuki Yamamoto% Done:

0%

Category:SylpheedSpent time:-
Target version:3.4

Description

Why:

I want to distinct HTML mail(text/plain,text/html) and other mail with attachments at a glance.
Currently, Sylpheed does not care about content of attachments for its icon.

Goal:

- use clip icon for mail with almost attachements at summaryview
- use other icon for HTML mail at summaryview

How:

Apply the attached patch for svn HEAD.

ref: http://d.hatena.ne.jp/kenhys/20120818

use-htmlmail-instead-of-clip.diff Magnifier (3.55 KB) Kentaro HAYASHI, 08/18/2012 05:51 PM

use-htmlmail-instead-of-clip-cached.diff Magnifier (5.03 KB) Kentaro HAYASHI, 08/22/2012 10:26 AM

use-htmlmail-instead-of-clip-cached.diff Magnifier (4.82 KB) Kentaro HAYASHI, 08/22/2012 10:46 PM

History

#1 Updated by Hiroyuki Yamamoto almost 2 years ago

I've looked into your patch.

It will scan all MIME messages every time a folder is open.
This will have the non-trivial impact on the performance.

I think it should be done in libsylph and its results should be cached in .sylpheed_cache.

#2 Updated by Kentaro HAYASHI almost 2 years ago

There is a performance problem certainly as you have mentioned above.

So, I have updated the patch which stores flags in .sylpheed_cache.
(Note that it occupies 1bit of MsgTmpFlags for HTML mail.)

#3 Updated by Kentaro HAYASHI almost 2 years ago

Kentaro HAYASHI wrote:

There is a performance problem certainly as you have mentioned above.

So, I have updated the patch which stores flags in .sylpheed_cache.
(Note that it occupies 1bit of MsgTmpFlags for HTML mail.)

Sorry, I have attached wrong patch. I will update later.

#4 Updated by Kentaro HAYASHI almost 2 years ago

I have updated the patch.

This patch fixes a bug that mime type is classified incorrectly as previous patch does.

#5 Updated by Hiroyuki Yamamoto almost 2 years ago

Kentaro HAYASHI wrote:

I have updated the patch.

This patch fixes a bug that mime type is classified incorrectly as previous patch does.

1. It is better to process MIME headers in procheader.c than in procmsg_write_cache().
The problem of the first patch will be solved by changing the definition of
MSG_CACHED_FLAG_MASK from (MSG_MIME) to (MSG_MIME|MSG_MIME_HTMLMAIL).
2. Created MimeInfo object is not freed.

#6 Updated by Hiroyuki Yamamoto almost 2 years ago

  • Status changed from New to In Progress

#7 Updated by Hiroyuki Yamamoto 11 months ago

  • Target version changed from 3.3 to 3.4

#8 Updated by Hiroyuki Yamamoto 11 months ago

I have modified your patch to:
  • process MIME header in procheader.c
  • replace HTML icon with Gnome's one
  • also treat HTML-only mail as HTML mail

and applied at svn r3281. Thanks!

#9 Updated by Hiroyuki Yamamoto 11 months ago

  • Status changed from In Progress to Resolved

#10 Updated by Kentaro HAYASHI 11 months ago

I was going to update patch at that time, but I have not done for a long time.
Anyway, I am glad to hear this feature is implemented! Thanks!!!

#11 Updated by Hiroyuki Yamamoto 8 months ago

  • Status changed from Resolved to Closed

#12 Updated by X. W. 7 months ago

Hello,

i just upgraded from Sylpheed 3.3.0 Win32 to Sylpheed 3.4beta7 Win32 and noticed the new icon for HTML e-mails (which was introduced in Sylpheed 3.4beta6).

But the new icon only appears for HTML e-mails which have been received with Sylpheed 3.4beta6 (and newer).

So, e-mails which already have been received with Sylpheed 3.4beta5 (and older) do still show the old attachment icon.

Is it possible to let the new HTML icon show up for e-mails which already have been received with Sylpheed 3.4beta5 (and older) as well?

If yes: how?

Regards

#13 Updated by D Sciurus 6 months ago

X. W. wrote:

Hello,

i just upgraded from Sylpheed 3.3.0 Win32 to Sylpheed 3.4beta7 Win32 and noticed the new icon for HTML e-mails (which was introduced in Sylpheed 3.4beta6).

But the new icon only appears for HTML e-mails which have been received with Sylpheed 3.4beta6 (and newer).

So, e-mails which already have been received with Sylpheed 3.4beta5 (and older) do still show the old attachment icon.

Is it possible to let the new HTML icon show up for e-mails which already have been received with Sylpheed 3.4beta5 (and older) as well?

If yes: how?

Regards

Ctrl+Alt+U or select Update the message summary in the View menu (main window)

Also available in: Atom PDF