Feature #89

Change icon for HTML mail and other mail with attachments at summaryview

Added by Kentaro HAYASHI 9 months ago. Updated 9 months ago.

Status:In Progress Start date:08/18/2012
Priority:Normal Due date:
Assignee:Hiroyuki Yamamoto % Done:

0%
Category:Sylpheed Spent time: -
Target version:3.3

Description

Why:

I want to distinct HTML mail(text/plain,text/html) and other mail with attachments at a glance.
Currently, Sylpheed does not care about content of attachments for its icon.

Goal:

- use clip icon for mail with almost attachements at summaryview
- use other icon for HTML mail at summaryview

How:

Apply the attached patch for svn HEAD.

ref: http://d.hatena.ne.jp/kenhys/20120818

use-htmlmail-instead-of-clip.diff (3.6 kB) Kentaro HAYASHI, 08/18/2012 05:51 pm

use-htmlmail-instead-of-clip-cached.diff (5 kB) Kentaro HAYASHI, 08/22/2012 10:26 am

use-htmlmail-instead-of-clip-cached.diff (4.8 kB) Kentaro HAYASHI, 08/22/2012 10:46 pm

History

#1
Updated by Hiroyuki Yamamoto 9 months ago

I've looked into your patch.

It will scan all MIME messages every time a folder is open.
This will have the non-trivial impact on the performance.

I think it should be done in libsylph and its results should be cached in .sylpheed_cache.

#2
Updated by Kentaro HAYASHI 9 months ago

There is a performance problem certainly as you have mentioned above.

So, I have updated the patch which stores flags in .sylpheed_cache.
(Note that it occupies 1bit of MsgTmpFlags for HTML mail.)

#3
Updated by Kentaro HAYASHI 9 months ago

Kentaro HAYASHI wrote:

There is a performance problem certainly as you have mentioned above.

So, I have updated the patch which stores flags in .sylpheed_cache.
(Note that it occupies 1bit of MsgTmpFlags for HTML mail.)

Sorry, I have attached wrong patch. I will update later.

#4
Updated by Kentaro HAYASHI 9 months ago

I have updated the patch.

This patch fixes a bug that mime type is classified incorrectly as previous patch does.

#5
Updated by Hiroyuki Yamamoto 9 months ago

Kentaro HAYASHI wrote:

I have updated the patch.

This patch fixes a bug that mime type is classified incorrectly as previous patch does.

1. It is better to process MIME headers in procheader.c than in procmsg_write_cache().
The problem of the first patch will be solved by changing the definition of
MSG_CACHED_FLAG_MASK from (MSG_MIME) to (MSG_MIME|MSG_MIME_HTMLMAIL).
2. Created MimeInfo object is not freed.

#6
Updated by Hiroyuki Yamamoto 9 months ago

  • Status changed from New to In Progress

Also available in: Atom PDF