Bug #53

Including individual glib headers no longer supported

Added by Ricardo Mones about 2 years ago. Updated about 2 years ago.

Status:ClosedStart date:03/25/2012
Priority:NormalDue date:
Assignee:Hiroyuki Yamamoto% Done:

0%

Category:SylpheedSpent time:-
Target version:3.2

Description

Hi Hiro,

This has been reported on Debian BTS today, but better than patching
the sources for Debian may be it could be integrated for wider benefit.

Quoting original submitter:

including individual glib headers has been deprecated for several years.

Starting with glib 2.32 it is now mandatory to include glib.h instead
of individual headers [1], or the compiler will generate an error.

With the notable exception of:
 glib/gi18n.h
 glib/gi18n-lib.h
 glib/gprintf.h
 glib/gstdio.h
Those header files are still meant to be included separately.

And the suggestion for fixing:
Usually, simply replacing #include <glib/foo.h> with #include <glib.h>
is all that is needed (while keeping the above list of exceptions in mind)
You can use the glib version from experimental to test if your package
builds correctly.

See full details in http://bugs.debian.org/665614.

Thanks in advance,

History

#1 Updated by Hiroyuki Yamamoto about 2 years ago

Ricardo Mones wrote:

This has been reported on Debian BTS today, but better than patching
the sources for Debian may be it could be integrated for wider benefit.

Quoting original submitter:

[...]
And the suggestion for fixing:
[...]

See full details in http://bugs.debian.org/665614.

Thanks for the report. I will fix it.

I've checked all glib includes in Sylpheed, and it seems that the source file in problem is
libsylph/defs.h (glibconfig.h and glib/gwin32.h) only.

And I've noticed that the script referred on the bug report
doesn't seem to handle the direct inclusion of glibconfig.h.

#2 Updated by Hiroyuki Yamamoto about 2 years ago

  • Status changed from New to Resolved

#3 Updated by Hiroyuki Yamamoto about 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF