Bug #134

sylpheed-3.4.0beta5: 3 * bad if test ?

Added by David Binderman 10 months ago. Updated 6 months ago.

Status:ClosedStart date:10/29/2013
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:-Spent time:-
Target version:-

Description

I just compiled sylpheed-3.4.0beta5 with the extra gcc flag -Wlogical-op

It said

1.

folderview.c:1560:2: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]

Source code is

if (item->stype != F_NORMAL || item->stype != F_VIRTUAL) return;

Suggest swap || for &&

2.

vcard.c:436:5: warning: logical 'and' of mutually exclusive tests is always false [-Wlogical-op]

if( ch > '0' && ch < ' ' ) d = ch - '0';

3.

rpop3.c:1320:6: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]

} else if (rpop3_window.session->state != POP3_DONE ||
rpop3_window.session->state != POP3_ERROR)

History

#1 Updated by Hiroyuki Yamamoto 10 months ago

  • Status changed from New to Resolved

Fixed at r3295. Thanks.

#2 Updated by Hiroyuki Yamamoto 6 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF